security: remove hard-coded API key from benchmark scripts#121
Open
antojoseph wants to merge 1 commit into
Open
security: remove hard-coded API key from benchmark scripts#121antojoseph wants to merge 1 commit into
antojoseph wants to merge 1 commit into
Conversation
Replace the committed live API key with DARKBLOOM_API_KEY env var lookup. Script exits immediately if the variable is unset to prevent silent failures.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eigeninference-...API key hard-coded inscripts/benchmark-models.pyandscripts/benchmark-light.pyDARKBLOOM_API_KEYenvironment variable; script exits immediately if unsetDARKBLOOM_API_URLcan optionally override the base URLImpact
Any user with read access to the repo could authenticate as a live service account. The key grants access to backend APIs.
The committed key should be revoked immediately regardless of this PR.
Test plan
DARKBLOOM_API_KEY=<new-key> python3 scripts/benchmark-models.pyto verify it workspython3 scripts/benchmark-models.pywith no env var set and verify it exits with an error message