[lua, sql, cpp] Add weighted weaponskill for trusts, useWeaponSkill on entity, and Valaineral updates#9708
Open
lefneer311 wants to merge 1 commit intoLandSandBoat:basefrom
Open
[lua, sql, cpp] Add weighted weaponskill for trusts, useWeaponSkill on entity, and Valaineral updates#9708lefneer311 wants to merge 1 commit intoLandSandBoat:basefrom
lefneer311 wants to merge 1 commit intoLandSandBoat:basefrom
Conversation
Implements weighted TP skill selection and integrates it into gambits and Lua bindings. Significantly expands Valaineral (trust) logic toward retail parity. - Adds weighted WS storage and selection logic - Exposes weighted WS handling to Lua - Updates Valaineral to use weighted WS behavior - Includes supporting SQL changes for skills and spells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This pull request does the following:
My changes were tested against a fresh Release x64 build pulled and compiled on 2026-03-31.
Steps to test these changes
For the weighted_ws modifications, you can modify any trust you like to include a weighted_ws table, and a gambit to make use of ai.s.WEIGHTED_WS, launch the server, summon that trust, and observe their weaponskill behavior. Reference Valaineral.lua for an example of how to add weights.
For the useWeaponSkill(), this is best demonstrated with Valaineral. Summon Valaineral, engage a mob and swing so Valaineral engages. Unlock from your target and use a spell or job ability (or another means of engaging) another mob. Bring that mob near Valaineral and watch him use Uriel Blade. The logic follows retail as closely as I'm aware of at this time.
Screenshots below are from tests performed against Wajaom Woodlands Lesser Colibri at level 75.