Skip to content

fix: apply bulk score deltas in correct direction #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silentgeckoaudit3801 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: apply bulk score deltas in correct direction #1411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d4eb38
fix: apply bulk score deltas in correct direction
silentgeckoaudit3801 Jul 23, 2026
f9bf635
Merge branch 'main' into fix-bulk-score-delta-sign
ogazboiz Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion backend/src/services/__tests__/scoresService-additions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,16 @@
const [sql] = mockQuery.mock.calls[0] as [string, unknown[]];
expect(sql).toContain('LEAST(850, GREATEST(300,');
});
});

it('applies positive deltas as score increases in bulk upserts', async () => {
await updateUserScoresBulk(new Map([['user_reward', 25]]));

const [sql, params] = mockQuery.mock.calls[0] as [string, unknown[]];
expect(params).toEqual(['user_reward', 25]);
expect(sql).toContain('500 + $2');
expect(sql).toContain('scores.current_score + EXCLUDED.current_score - 500');
expect(sql).not.toContain('500 - $2');
});});

Check failure on line 94 in backend/src/services/__tests__/scoresService-additions.test.ts

View workflow job for this annotation

GitHub Actions / backend 

Insert `⏎`

describe('setAbsoluteUserScoresBulk', () => {
it('is a noop for empty map', async () => {
Expand Down
2 changes: 1 addition & 1 deletion backend/src/services/scoresService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export async function updateUserScoresBulk(
// Clamped the initial raw value payload insertion step to prevent violating constraints on initial inserts
const valuePlaceholders = Array.from(
{ length: params.length / 2 },
(_, i) => `($${i * 2 + 1}, LEAST(850, GREATEST(300, 500 - $${i * 2 + 2})))`,
(_, i) => `($${i * 2 + 1}, LEAST(850, GREATEST(300, 500 + $${i * 2 + 2})))`,
).join(', ');

const sql = `
Expand Down
Loading