Add CraftEngine item rendering support#104
Open
Mrcuttlefish wants to merge 2 commits into
Open
Conversation
… custom items properly. - Bumped version to 2026.1.0.2
Owner
|
Thanks for the PR! However, could it be done by registering the transformer on IC side here? You can take a look at the EcoEnchants hook. |
Author
|
I think it can, I focused here because it was not showing in the previews but I think I can modify the other hook to pass through the items and show the correct preview. |
Owner
|
Using the API is probably better, as you get the additional benefit of having the transformed item in the chat events too (for lore and stuff). |
Author
|
I spent the last bit trying to get it to work via registering a transformer but I was not able to. I believe this is due to how Craftengine choses to render custom items however I was able to consistently get it to work here. I only added a hook to grab the CE texture pack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional CraftEngine support to InteractiveChatDiscordSrvAddon item rendering.
This fixes CraftEngine custom items/blocks not rendering correctly. ICD will still need the resourcepack to render the items properly.