feat(composer): allow switching Enter vs Shift+Enter to send - #1022
Merged
Conversation
Add a persisted composerSendKey setting so users can choose whether Enter or Shift+Enter sends from the chat composer, with the other key inserting a newline. Co-authored-by: Cursor <cursoragent@cursor.com>
XingYu-Zhong
force-pushed
the
codex/composer-send-key
branch
from
July 25, 2026 14:29
d1f3147 to
ce65540
Compare
Collaborator
Rebase + review已把本 PR rebase 到最新
审查结论:建议合入(功能有价值,实现也基本到位)做得好的地方
本地已验证
残留小问题(不阻塞合入,可后续跟)
CI 跑绿后即可合。 |
XingYu-Zhong
approved these changes
Jul 25, 2026
XingYu-Zhong
left a comment
Collaborator
There was a problem hiding this comment.
LGTM after rebase onto develop.
Verified locally: focused vitest (128) + typecheck. Default remains Enter-to-send; setting is persisted and applied live. Footer shortcut hint now follows the selected send key.
Residual non-blocking: some placeholders still hardcode Shift+Enter-for-newline copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composerSendKeysetting (enter|shiftEnter) so users can choose whether Enter or Shift+Enter sends from the chat composer.@mention commit on Enter when the mention menu is open, and include the setting in settings migrate/export paths.Changes
Tests
npx vitest run src/shared/app-settings.test.ts src/shared/app-settings-domain.test.ts src/renderer/src/locales/locale-resources.test.ts src/renderer/src/components/settings-section-general.test.tsnpm run typecheckMade with Cursor