TokenUsageTask returns early if info is present by didierofrivia · Pull Request #408 · Kuadrant/wasm-shim

didierofrivia · 2026-07-30T08:18:25Z

This PR introduces an early check for fields present in order to avoid doing the hard work. It's also useful when external proceses can inject these type of fields and the wasm-shim can be alleviated from doing the body parsing.

Summary by CodeRabbit

Bug Fixes
- Response processing now completes immediately when all expected response fields are already available.
- Prevents unnecessary extraction and waiting for additional response data in these cases.
Performance
- Reduces processing overhead and improves response handling efficiency when required fields have already been captured.

coderabbitai · 2026-07-30T08:18:46Z

Warning

Review limit reached

@didierofrivia, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a541441-3461-4368-9bac-d89714aef956

📥 Commits

Reviewing files that changed from the base of the PR and between 8ccf948 and ab50334.

📒 Files selected for processing (1)

crates/kuadrant-filter/src/kuadrant/pipeline/tasks/token_usage.rs

📝 Walkthrough

Walkthrough

TokenUsageTask::apply now exits with TaskOutcome::Done when all expected response fields are already present, avoiding unnecessary extraction and response-stream handling.

Changes

Token usage processing

Layer / File(s)	Summary
Existing response field completion `crates/kuadrant-filter/src/kuadrant/pipeline/tasks/token_usage.rs`	Checks whether every expected response field exists before selecting an extraction strategy or waiting for response data.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: adam-cattermole, eguzki

Poem

A rabbit checks the fields in a row,
Finds them all ready, and says “off we go!”
No bytes to buffer, no stream left to chase,
The task hops away at a brisker pace.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: TokenUsageTask now exits early when the needed information is already present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch check-stored-tokens-first

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

🧹 Nitpick comments (1)

crates/kuadrant-filter/src/kuadrant/pipeline/tasks/token_usage.rs (1)
47-54: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add regression coverage for the early-exit path.

Pre-populate all expected response fields and assert TaskOutcome::Done; also cover the partial-field case to verify extraction still proceeds.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/kuadrant-filter/src/kuadrant/pipeline/tasks/token_usage.rs` around
lines 47 - 54, Add regression tests for the early return in the token-usage
task: pre-populate every field listed in expected_response_fields and assert
execution returns TaskOutcome::Done, then add a partial-field case that confirms
extraction continues rather than exiting early.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@crates/kuadrant-filter/src/kuadrant/pipeline/tasks/token_usage.rs`:
- Around line 47-54: Add regression tests for the early return in the
token-usage task: pre-populate every field listed in expected_response_fields
and assert execution returns TaskOutcome::Done, then add a partial-field case
that confirms extraction continues rather than exiting early.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d62d4e3c-d6cd-490b-b133-674c1bc46aa8

📥 Commits

Reviewing files that changed from the base of the PR and between f86c2ba and 8ccf948.

📒 Files selected for processing (1)

crates/kuadrant-filter/src/kuadrant/pipeline/tasks/token_usage.rs

adam-cattermole · 2026-07-30T08:35:36Z

@@ -44,6 +44,16 @@ impl Task for TokenUsageTask {
    fn apply(self: Box<Self>, ctx: &mut ReqRespCtx) -> TaskOutcome {


It's worth noting this task is legacy and (very) soon to be removed in favour of the StoreTask

nice! yup, I reckon this would be just for a PoC I'm working on... Do you reckon that the resulting config from a TokenRateLimit Policy will change the configuration that will result building the Pipeline with the StoreTask or would it be the same?

Yeah, so all the bits will be extracted from the responseBodyJson vars and added to a StoreTask. So any task leveraging them will wait Pending until the StoreTask resolves for them

* If response body fields are present. * Avoids doing the work twice. Signed-off-by: dd <4183971+didierofrivia@users.noreply.github.com>

didierofrivia · 2026-08-03T10:15:13Z

Closing this since task will be deprecated soon

didierofrivia requested review from adam-cattermole and eguzki July 30, 2026 08:18

didierofrivia self-assigned this Jul 30, 2026

kuadrant-dev added this to Kuadrant Jul 30, 2026

didierofrivia moved this to Ready For Review in Kuadrant Jul 30, 2026

coderabbitai Bot reviewed Jul 30, 2026

View reviewed changes

adam-cattermole reviewed Jul 30, 2026

View reviewed changes

refactor(task): TokenUsageTask returns early

ab50334

* If response body fields are present. * Avoids doing the work twice. Signed-off-by: dd <4183971+didierofrivia@users.noreply.github.com>

didierofrivia force-pushed the check-stored-tokens-first branch from 8ccf948 to ab50334 Compare July 30, 2026 08:48

didierofrivia closed this Aug 3, 2026

github-project-automation Bot moved this from Ready For Review to Done in Kuadrant Aug 3, 2026

coderabbitai Bot mentioned this pull request Aug 7, 2026

Burn legacy config #412

Open

Navigation Menu

Uh oh!

TokenUsageTask returns early if info is present - #408

TokenUsageTask returns early if info is present#408
didierofrivia wants to merge 1 commit into
mainfrom
check-stored-tokens-first

didierofrivia commented Jul 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

adam-cattermole Jul 30, 2026 •

edited

Loading

Uh oh!

didierofrivia Jul 30, 2026

Uh oh!

adam-cattermole Jul 30, 2026

Uh oh!

adam-cattermole Aug 3, 2026

Uh oh!

didierofrivia commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -44,6 +44,16 @@ impl Task for TokenUsageTask {
		fn apply(self: Box<Self>, ctx: &mut ReqRespCtx) -> TaskOutcome {

Uh oh!

Conversation

didierofrivia commented Jul 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

adam-cattermole Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

didierofrivia Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

adam-cattermole Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

adam-cattermole Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

didierofrivia commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

didierofrivia commented Jul 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

adam-cattermole Jul 30, 2026 •

edited

Loading