Pin yq installation to a specific version via a shared composite action - #658
Closed
Boomatang wants to merge 1 commit into
Closed
Pin yq installation to a specific version via a shared composite action#658Boomatang wants to merge 1 commit into
Boomatang wants to merge 1 commit into
Conversation
The installing of yq has being moved in to its own action. As yq is used across a number of workflows this give on location to update the version. Signed-off-by: Jim Fitzpatrick <jfitzpat@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces inline yq installation steps across CI workflows with a shared composite action (
.github/actions/install-yq) that pins yq to a specific version (4.53.3) instead of pulling fromlatest.This change was prompted by review feedback suggesting that yq should be pinned to a specific version to avoid potentially breaking CI on external updates. Branch protections on
release_processprevent pushing directly, so this is submitted as a separate PR.Changes
mikefarah/yq, with the version configurable via an input parameterrelease.yaml,version-gate.yaml, andpre-release.yamlworkflows to use the new composite action instead of inline installation stepspre-release.yamlwhich used yq without installing it firstNotes
4.53.3and can be overridden per-caller via theversioninput