[OptApp][SIApp] Clamper projection - #14677
Open
talhah-ansari wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@sunethwarna I moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR migrates the
SmoothClamperutility from theSystemIdentificationApplicationto theOptimizationApplication, refactors the Python bindings and usage accordingly, and introduces aClampingProjectionfor controlling and projecting variable bounds. It also updates the relevant tests and integrates the new projection utility into the control workflow.🆕 Changelog
smooth_clamper.cpp,smooth_clamper.h, and their test fromSystemIdentificationApplicationtoOptimizationApplication.SmoothClamperonly inOptimizationApplication, removing it fromSystemIdentificationApplicationand adding it to the new location.ClampingProjectionclass inopt_projection.pyto generalize clamping/projection of design variables, with helper classTensorAdaptorBoundingManagerfor interval management. Registeredclamping_projectionas a supported projection type.TensorAdaptorBoundingManagerfromtensor_adaptor_utils.pyinSystemIdentificationApplicationto a helper class inopt_projection.pybecause it is the only place it's being used and thus avoids dependency of OptApp on SIApp.data_values_control.pyto use the new projection utility instead of directly managingSmoothClamperand interval bounding.test_smooth_clampertest to the new location and ensured it is included in the test suite forOptimizationApplication.optimization_analysis.pyto ensure processes are created and initialized inInitialize().