Bind Android local servers to loopback#303
Open
lumen-for-kairunkr wants to merge 1 commit into
Open
Conversation
Author
|
Opened #304 to ask about the intended Android bind behavior and whether any cross-device/LAN workflow depends on the current |
Author
|
Hi, just following up on this PR. The proposed change keeps the Android Web UI and AnkiConnect-style bridge bound to If No rush — just wanted to check whether this direction fits the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1instead of0.0.0.0127.0.0.1instead of0.0.0.0Rationale
The Android WebView/native app flows use loopback URLs, so the local servers do not need to listen on all network interfaces by default.
Listening on
0.0.0.0makes these local helper services reachable from other devices on the same Wi-Fi/LAN. That is broader than the same-device WebView use case and can be surprising on public or shared networks, especially because the Android Web UI and AnkiConnect-style bridge expose app-local actions over HTTP. Binding to loopback by default keeps the existing same-device flow working while avoiding unnecessary network exposure.If cross-device/LAN access is intended for some workflows, it would be safer as an explicit opt-in setting rather than the default bind behavior.
Test plan
127.0.0.1)KolbyML/Manatan:master