This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Optimize IN comparion by using a map instead of slice when possible#189
Open
Richtermeister wants to merge 3 commits into
Open
Optimize IN comparion by using a map instead of slice when possible#189Richtermeister wants to merge 3 commits into
Richtermeister wants to merge 3 commits into
Conversation
Richtermeister
force-pushed
the
optimize-in
branch
from
ff1719c to
2b46f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to optimize
INexpressions with static clauses. The example benchmarka in (1, 2, 3, 4, 5, 6, 7, 8, 9, 10)included is rather small but illustrates the point, especially since allocations grow in proportion to number of entries involved. In production we have expressions against 40k+INentries, which massively benefits from this optimization.