fix(kiloclaw): google setup improvements#1184
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)N/A Files Reviewed (5 files)
Reviewed by gpt-5.4-20260305 · 682,632 tokens |
jeanduplessis
approved these changes
Mar 17, 2026
The sed cleanup previously deleted from `## Google Workspace` to EOF, which would nuke any content appended after that section. Use explicit `<!-- BEGIN:google-workspace -->` / `<!-- END:google-workspace -->` markers so only the bounded block is removed on disconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/terms/iregex instead of brittleincludes('Terms of Service')for GCP project creation error handlingencodeURIComponent()for push endpoint/audience URLs and regex sanitization for Pub/Sub subscription names, preventing breakage when user IDs contain/updateGoogleCredentialsnow setsgmailNotificationsEnabled: trueupon connecting a Google account (disconnect already resets tofalse)start-openclaw.shwhenKILOCLAW_GOG_CONFIG_TARBALLis set, so the openclaw agent knowsgogis availableTest plan