feat(kiloclaw): enable gmail push notifications by default on Google account connect#1143
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
feat(kiloclaw): enable gmail push notifications by default on Google account connect#1143kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
|
|
||
| this.s.googleCredentials = credentials; | ||
| this.s.gmailPushOidcEmail = credentials.gmailPushOidcEmail ?? null; | ||
| this.s.gmailNotificationsEnabled = true; |
Contributor
Author
There was a problem hiding this comment.
WARNING: Reconnecting a different Google account will reuse the old Gmail cursor
updateGoogleCredentials() now re-enables push delivery immediately, but it still leaves gmailLastHistoryId untouched. That value is injected back into the controller on startup via KILOCLAW_GMAIL_LAST_HISTORY_ID, so switching from account A to account B can patch B's gog state with A's history ID and make Gmail watch resume from an invalid position. Reset the stored history ID when replacing credentials.
Contributor
Author
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)N/A Files Reviewed (3 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-20260305 · 1,123,449 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gmailNotificationsEnabled) are now automatically enabled when a user connects a Google account viaupdateGoogleCredentials(), instead of defaulting to off and requiring a manual toggle.Verification
pnpm --filter kiloclaw test— all 665 tests pass, including a new test for the auto-enable behaviorclearGoogleCredentials(resets tofalse) andupdateGmailNotifications(manual toggle) continue to pass unchangedVisual Changes
N/A
Reviewer Notes
The change is scoped to
updateGoogleCredentials()in the KiloClaw Instance DO — it now setsgmailNotificationsEnabled: truealongside storing the credentials and OIDC email. The schema default (false),createMutableState(), andresetMutableState()remain unchanged because those represent the initial/disconnected state.clearGoogleCredentials()still resets tofalse, so disconnecting Google correctly disables notifications.Built for Igor by Kilo for Slack