fix(kiloclaw): remove iad from default Fly region list#1131
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
fix(kiloclaw): remove iad from default Fly region list#1131kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| * Callers shuffle before selecting so order here doesn't matter. | ||
| * ord omitted due to provisioning issues. */ | ||
| export const DEFAULT_FLY_REGION = 'dfw,ewr,iad,lax,sjc,eu'; | ||
| export const DEFAULT_FLY_REGION = 'dfw,ewr,lax,sjc,eu'; |
Contributor
Author
There was a problem hiding this comment.
WARNING: This fallback no longer matches the checked-in worker config
kiloclaw/wrangler.jsonc still sets FLY_REGION to dfw,ewr,iad,lax,sjc,eu, and the provisioning code prefers env.FLY_REGION over DEFAULT_FLY_REGION. In any environment that uses that config, iad will still be selected and this change will have no effect.
Contributor
Author
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 468,172 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
iad(Ashburn, VA) from the default Fly region list in KiloClaw. This updates theDEFAULT_FLY_REGIONconstant inkiloclaw/src/config.tsfromdfw,ewr,iad,lax,sjc,eutodfw,ewr,lax,sjc,eu, and updates the corresponding test assertions inkiloclaw/src/durable-objects/kiloclaw-instance.test.tsto match.Verification
pnpm test -- --run— all 664 tests pass across 36 test filesiadreferences in region lists were removed; standaloneregion: 'iad'values in test fixtures (machine/volume mocks) were intentionally left unchanged as they represent individual region assignments, not the default region listVisual Changes
N/A
Reviewer Notes
The test file contains many
region: 'iad'references for individual machine/volume fixtures — these are arbitrary region values and are unrelated to the default region list. Only theFLY_REGIONenv var string and the sorted region array assertions (3 occurrences in 412 insufficient-resources recovery tests) were updated.Built for Florian by Kilo for Slack