Conversation
…er rules)
npx eslint src/ now passes with 0 problems (was 12: 7 errors + 5 warnings).
- Donut: compute segment offsets functionally (no in-render acc += mutation) → render-pure, satisfies react-hooks/immutability legitimately.
- finance/[id]: memo deps [subjects, txn] match the compiler-inferred dep (react-hooks/preserve-manual-memoization).
- use-color-scheme.web: useSyncExternalStore (server snapshot 'light') instead of a mount-effect hydration flag → no react-hooks/set-state-in-effect; same SSR-safe behavior.
- sign-in: drop unused AuthMethod import. csv: readonly (readonly T[])[] type. db/index{,.web}: drop stale no-console disables.
- eslint.config: disable react-hooks/immutability (a React-Compiler-only rule; this app doesn't run the compiler and Reanimated mutates shared values via .value by design — false positives in ui/Sheet). All other react-hooks rules stay on.
tsc clean · expo export clean (24 routes) · runtime: Donut renders both themes, «Авто» follows system dark↔light, 0 console errors.
Clean up 12 pre-existing lint problems (React Compiler rules)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the Phase 0-2 lint cleanup (12→0 problems) from dev to main. tsc + expo export clean; runtime-verified (Donut both themes, system-follow theme, 0 console errors). No behavior change.