Allow multiple trusted CORS hosts instead of only one#95
Open
iekilinc wants to merge 13 commits intoKamWithK:masterfrom
Open
Allow multiple trusted CORS hosts instead of only one#95iekilinc wants to merge 13 commits intoKamWithK:masterfrom
iekilinc wants to merge 13 commits intoKamWithK:masterfrom
Conversation
This reverts commit eac80c0. It's already ensured at this point that it's not empty.
KamWithK
requested changes
Mar 1, 2026
Owner
KamWithK
left a comment
KamWithK
left a comment
There was a problem hiding this comment.
I was on the edge about whether we need this but I've decided it has its uses
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/RouteHandler.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/RouteHandler.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/RouteHandler.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/RouteHandler.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/RouteHandler.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kamwithk/ankiconnectandroid/SettingsActivity.java
Outdated
Show resolved
Hide resolved
This reverts commit a322313.
iekilinc
commented
Mar 1, 2026
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/RouteHandler.java
Outdated
Show resolved
Hide resolved
iekilinc
commented
Mar 1, 2026
KamWithK
requested changes
Mar 7, 2026
app/src/main/java/com/kamwithk/ankiconnectandroid/routing/RouteHandler.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the user can only have one trusted host. My use case is that I want to add, for example, Mokuro Reader, asbplayer, and Mangatan to the CORS hosts instead of only one of them. Right now, the user is forced to either enable all with
"*", which is insecure, or they're forced to switch betweenhttps://app.mokuro.reader,https://app.asbplayer.dev, andhttp://wherever-theyre-hosting-mangatan:4568, which is quite inconvenient.Also, the example text that should show up for the CORS setting was not being displayed due to a mismatch of strings, so that's also fixed.