docs: correct default orth algorithm in KrylovDefaults docstring#167
Merged
Conversation
The docstring previously referenced KrylovKit.ModifiedGramSchmidtIR() as the default, but the actual default is ModifiedGramSchmidt2().
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 88.42% 86.59% -1.83%
==========================================
Files 36 36
Lines 3964 3917 -47
==========================================
- Hits 3505 3392 -113
- Misses 459 525 +66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for the PR, this contribution is definitely greatly appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring of
KrylovDefaultspreviously referencedKrylovKit.ModifiedGramSchmidtIR()as the default, but the actualdefault is
KrylovKit.ModifiedGramSchmidt2().