add lenstra eliptic curve factoring#104
Open
oscardssmith wants to merge 3 commits into
Open
Conversation
Member
Author
|
some benchmarks: These are the bad cases for ecm (when all the factors are of similar size). That said, ecm tends to do a bunch better for larger inputs, and for numbers with a few smaller factors. This implementation is not especially optimized, but I think it is a good baseline for future improvements. |
Merged
63fe1a0 to
0f17131
Compare
7dc85ad to
afb4498
Compare
afb4498 to
42f0316
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 93.52% 94.97% +1.45%
==========================================
Files 2 2
Lines 463 517 +54
==========================================
+ Hits 433 491 +58
+ Misses 30 26 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
With a little help from claude, I now have this working a lot faster (due to a better basis for curve and adding stage 2).
|
Member
Author
|
@s-celles tagging you here cause I figure you may be interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heavily inspired by @trizen, but refactored a little to make it more reliable.