Skip to content

Fix Awaiting of setAlertConfig in CI/CD Alerts Route #9011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JhaSourav07 merged 1 commit into from
Aug 13, 2026
+2 −1
Merged

Fix Awaiting of setAlertConfig in CI/CD Alerts Route #9011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/api/cicd/alerts/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
);
}

setAlertConfig(body.repository, {
// Await async call to prevent unhandled promise rejections and ensure write completes before responding
await setAlertConfig(body.repository, {
enabled: body.enabled ?? true,
onFailure: body.onFailure ?? true,
onSuccess: body.onSuccess ?? false,
Expand All @@ -81,7 +82,7 @@
}
}

export async function GET(request: NextRequest) {

Check warning on line 85 in app/api/cicd/alerts/route.ts

View workflow job for this annotation

GitHub Actions / Format · Lint · Typecheck · Test 

'request' is defined but never used. Allowed unused args must match /^_/u
return NextResponse.json({
message: 'Alert configuration endpoint',
usage: {
Expand Down
Loading