feat: Enhance SVG Tower Tooltips with Interactivity - #8980
Conversation
|
@Aditya8369 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request enhances the SVG graphs by making the tower tooltips interactive, which aligns with our previous decisions on improving user interactions and testing for SVG components. The addition of unit tests ensures that the new features are stable and reliable. Great work on this! Looking forward to seeing it merged. |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
|
@JhaSourav07 @Aamod007 please check this |
Aamod007
left a comment
There was a problem hiding this comment.
Beautiful enhancement! Grouping the SVG towers and utilizing native <title>\ tags in \generator.ts\ is the perfect, zero-JavaScript way to add tooltips that work reliably across GitHub READMEs. The added CSS micro-animations (\ ransform: translateY(-4px)\ on hover) really elevate the premium feel of the monolith.
The tests in \generator.interactive-tooltips.test.ts\ thoroughly ensure the structure is generated correctly and, crucially, that reserved XML characters are properly escaped to prevent invalid SVG output.
Labels applied:
- type:feature, type:design: Adds interactive tooltips and hover effects to the SVG graphs.
- level:intermediate: Handles SVG DOM grouping, native browser tooltips, and embedded CSS.
- quality:exceptional: Clean, accessible, and very well tested implementation.
|
🎉 Congratulations @Aditya8369! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Monolith towers in SVG graphs are now interactive and explorable:
SVG Grouping & Structure: Towers in
generator.ts
are grouped inside tags with explicit data-date and data-count metadata attributes.
Native Browser Tooltips & Accessibility: Each tower group contains a <title> tag (e.g. <title>TODAY: Oct 26: 5 commits</title>) to natively display tooltips on hover across all browsers without JavaScript, ensuring compatibility with GitHub READMEs and screen reader accessibility.
CSS Micro-Animations: Smooth hover transformations (translateY(-4px)), brightness adjustments, drop-shadow glow, and cursor: pointer styling are applied via .interactive-tower:hover in the SVG <style> block.
Unit Testing: Added
generator.interactive-tooltips.test.ts
. All 180 unit tests across the SVG generator and layout test suites passed cleanly.
For full details, please review the
closes #8975