Skip to content

Enhance GitHub Username Validation to Prevent GraphQL Injection Attacks #8576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshul23102 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance GitHub Username Validation to Prevent GraphQL Injection Attacks #8576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,18 @@ const timeZoneParam = z
.optional()
.refine(isValidTimeZone, { message: 'Invalid timezone' });

export const GITHUB_USERNAME_REGEX = /^[a-z\d](?:[a-z\d]|-(?=[a-z\d])){0,38}$/i;
// GitHub username validation: 1-39 characters, alphanumeric and hyphens only
// Must start and end with alphanumeric, cannot have consecutive hyphens
export const GITHUB_USERNAME_REGEX = /^[a-zA-Z0-9]([a-zA-Z0-9-]{0,37}[a-zA-Z0-9])?$/;

export const githubUsernameSchema = z
.string({ error: 'Invalid GitHub username' })
.trim()
.min(1, { message: 'Invalid GitHub username' })
.max(39, { message: 'Invalid GitHub username' })
.min(1, { message: 'Invalid GitHub username: username is required' })
.max(39, { message: 'Invalid GitHub username: username cannot exceed 39 characters' })
.regex(GITHUB_USERNAME_REGEX, {
message: 'Invalid GitHub username',
message:
'Invalid GitHub username: must contain only alphanumeric characters and hyphens, starting and ending with alphanumeric',
});

const baseStreakParamsSchema = z.object({
Expand Down
Loading