fix: resolve mobile E2E test failures with robust notification system #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix still failed on mobile-safari due to timing sensitivity in the Math.ceil day calculation. The test now sets up conferences for ALL three notification thresholds (7, 3, and 1 days) using a calculation that ensures Math.ceil rounds correctly: (days - 0.5) * 86400000ms. This approach guarantees at least one threshold will trigger regardless of millisecond-level timing variations between browsers.
The notification system was using Math.ceil() for day calculations which caused timing-sensitive failures. A deadline set to "7 days from now" might calculate as 6.9 or 7.1 days depending on the exact millisecond, causing the exact match `[7, 3, 1].includes(daysUntil)` to fail intermittently. Changes: - Added isWithinNotificationWindow() helper that checks if daysUntil is within ±0.5 days of a threshold (24-hour window) - Added findMatchingThreshold() to find which threshold applies - Updated checkActionBarNotifications() to use range-based matching - Updated checkUpcomingDeadlines() to use range-based matching - Simplified E2E test now that production code is robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Key fixes: