Skip to content

Conversation

@staylorjlab
Copy link
Contributor

Further cleanup of track candidate code. Replaces multiple CDC/FDC matching methods, most of which were not efficient but wasted CPU cycles anyway, with much more simplified code. Removes dependence on reference trajectory and magnetic field swimmer. Removes reliance on DTrackingData in DTrackCandidate.h.

staylorjlab and others added 13 commits November 14, 2025 11:45
…f the features of this class. Remove reference trajectory and pulls, and add momentum, position and charge as explicit members of the DTrackCandidate class. Add lists of cdc and fdc hits explicitly to the class instead of using associated objects, thereby maintaining the order. Add first and last package indexes for FDC candidates. Add minimum drift time.
…ny methods to try to handle all sorts of edge conditions. Most of the time only one or two of the same subset of methods actually worked; the rest just wasted cpu cycles for marginal or no additional benefit.
@gluex
Copy link

gluex commented Nov 19, 2025

@aaust
Copy link
Contributor

aaust commented Nov 20, 2025

For 2017 (30300_000), I see a 3% drop in rho yields for this PR compared to the current master:
p2pi_30300
This adds to the approximate 1% loss introduced by #1069.
The loss is smaller for younger run periods, so there may be an energy dependence.

@aaust
Copy link
Contributor

aaust commented Nov 20, 2025

The tracks reconstructed with this PR have a significantly lower number of hits associated to them.
possdchitspertrack png
As a consequence, the matching efficiency to all timing detectors is degraded. This becomes especially apparent in the periphery of the TOF and the FCAL:
TOFR_match
This matching also has an effect on the number of neutral showers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants