Skip to content

[AUTOMATED-PR] Update imslib.min.js dependency#3

Open
github-actions[bot] wants to merge 21 commits into
stagefrom
update-imslib
Open

[AUTOMATED-PR] Update imslib.min.js dependency#3
github-actions[bot] wants to merge 21 commits into
stagefrom
update-imslib

Conversation

@github-actions
Copy link
Copy Markdown

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Jun 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@github-actions
Copy link
Copy Markdown
Author

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@JackySun9 JackySun9 self-requested a review as a code owner June 27, 2024 17:00
JackySun9 pushed a commit that referenced this pull request May 29, 2025
…led." (adobecom#4053)

Revert "Gap is seen between promo banner and G-nav when page is scrolled. (#3…"

This reverts commit 6bedeae.
JackySun9 pushed a commit that referenced this pull request Oct 9, 2025
* MWPW-179531-179764 Brand Concierge - Update Error and Loading Messages

* MWPW-179921-179531 Brand Concierge Styling Config (#3)

* remove new message border

* remove prompt suggestion border
JackySun9 added a commit that referenced this pull request May 20, 2026
Three rollbacks based on the 29 min regression observed with the
4-shard matrix:

1. matrix back to 3-shard (chrome, ipad, iphone full). With only 6
   runners, 4-shard meant 1.5 sites concurrent and merge jobs got
   starved waiting for capture jobs to free runners. 3-shard fits
   2 sites concurrently → better throughput in our pool size.

2. Drop actions/cache@v4 for node_modules in all three workflows.
   Restore step took ~57 s — not faster than `npm ci` on a warm
   `actions/setup-node` cache (~25 s), and added a Post-cache upload
   step at the end. Net no win.

3. Slim the merge job to `npm install --no-save --no-package-lock
   @aws-sdk/client-s3` instead of full `npm ci`. Merge only needs S3
   upload; doesn't need playwright, axios, or anything else. Save
   ~50 s on the merge job.

To make #3 possible, `lib/utils.js`'s playwright-core import is now
lazy (loaded inside compareScreenshots() rather than at top of file).
merge.js only uses validatePath which doesn't need playwright-core.

Also rolled back `__config__.waitStrategy: scroll` on bacom-blog.
The scroll dance made iphone diff jump 14/18 → 18/18 (100%) — scroll
position appears to materially change mobile content rendering on
those URLs. Default `footer` wait is fine for this site.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants