Skip to content

Fix Moment Frame example#311

Closed
jonbiemond wants to merge 1 commit into
JWock82:mainfrom
jonbiemond:fix-moment-frame-example
Closed

Fix Moment Frame example#311
jonbiemond wants to merge 1 commit into
JWock82:mainfrom
jonbiemond:fix-moment-frame-example

Conversation

@jonbiemond
Copy link
Copy Markdown
Contributor

Regression introduced by d302d46
Update the argument to the new name.

Regression introduced by d302d46
Update the argument to the new name.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.69%. Comparing base (4a81b0c) to head (e661a86).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   70.69%   70.69%           
=======================================
  Files          23       23           
  Lines        9474     9474           
=======================================
  Hits         6698     6698           
  Misses       2776     2776           
Flag Coverage Δ
unittests 70.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JWock82
Copy link
Copy Markdown
Owner

JWock82 commented Mar 27, 2026

Switching from combo_tags to combo_name was an intentional change last week to bring consistency across all functions. It is admittedly a breaking change for many users.

@JWock82 JWock82 closed this Mar 27, 2026
@jonbiemond
Copy link
Copy Markdown
Contributor Author

I ran the example on the latest code, and confirmed it is broken. The argument should be combo_tags, not combo_name.

@jonbiemond
Copy link
Copy Markdown
Contributor Author

jonbiemond commented Apr 15, 2026

@JWock82 Could you please take another look at this when you have a chance? It is blocking #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants