feat: add containerized test runner with runc.sh and Dockerfile#3391
Merged
feat: add containerized test runner with runc.sh and Dockerfile#3391
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a containerized test runner to make it easier to execute the repository’s regression tests in a consistent Linux environment (via podman/docker), while keeping existing Nix-based workflows intact.
Changes:
- Introduces
runner/runc.shto build/run a test container (with distro selection and optional host/nixbind-mount). - Adds
runner/Dockerfile+runner/entrypoint.shto provision bash/coreutils and bootstrap Nix inside the container before executing test commands. - Updates
README.mdwith container usage instructions and extendsflake.nixdev shell inputs (procps).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| runner/runc.sh | New container build/run wrapper with distro selection, repo mounting, and .bin compatibility checks. |
| runner/entrypoint.sh | Container entrypoint that configures Nix and executes the requested command inside the mounted repo. |
| runner/Dockerfile | Minimal image wrapper to ensure bash/coreutils exist and install the entrypoint. |
| README.md | Adds “Running Tests in a Container” documentation and examples. |
| flake.nix | Adds procps to devShells.base inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkoura
force-pushed
the
tests_in_container
branch
from
82f8db7 to
b79e211
Compare
- Introduce `runner/runc.sh` script to build and run tests inside a container using podman or docker, with support for Alpine, NixOS, Ubuntu, Debian, and Mint images. - Add `runner/Dockerfile` and `runner/entrypoint.sh` to set up the container environment, including Nix profile sourcing and command execution. - Update README with instructions for running tests in a container, including usage examples and options. - Add `procps` to devShells.base in flake.nix for improved shell compatibility.
mkoura
force-pushed
the
tests_in_container
branch
from
b79e211 to
5e1eb01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runner/runc.shscript to build and run tests inside a container using podman or docker, with support for Alpine, NixOS, Ubuntu, Debian, and Mint images.runner/Dockerfileandrunner/entrypoint.shto set up the container environment, including Nix profile sourcing and command execution.procpsto devShells.base in flake.nix for improved shell compatibility.