Skip to content

fix(mlp): enhance mlp_layer_fusion#382

Open
yingtongxiong wants to merge 4 commits intoInternLM:developfrom
yingtongxiong:fix/mlp_layer_fusion
Open

fix(mlp): enhance mlp_layer_fusion#382
yingtongxiong wants to merge 4 commits intoInternLM:developfrom
yingtongxiong:fix/mlp_layer_fusion

Conversation

@yingtongxiong
Copy link
Collaborator

Motivation

  1. The mlp_layer_fusion config is useful in MoE; therefore, a warning is added to recommend that users set this config to True in the MoE model.
  2. When testing MoE model, the call of delattr in launch.py will raise the AttributeError even though the attribute exists. Therefore, add the delattr method in Config Class.
  3. Refactor the mlp's forward.

Modification

  1. internlm/core/context/parallel_context.py
  2. internlm/initialize/launch.py
  3. internlm/model/modules/mlp.py

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants