Skip to content

Fixed bug that ME Bridge could void chemicals during exporting/importing - #781

Merged
SirEndii merged 2 commits into
IntelligenceModding:dev/1.21.1from
MineCake147E:dev/1.21.1-me-bug-fix
Sep 8, 2025
Merged

Fixed bug that ME Bridge could void chemicals during exporting/importing#781
SirEndii merged 2 commits into
IntelligenceModding:dev/1.21.1from
MineCake147E:dev/1.21.1-me-bug-fix

Conversation

@MineCake147E

Copy link
Copy Markdown
Contributor
  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

    • MEBridgePeripheral.exportChemical voids chemicals when the target peripheral couldn't fit all the amount extracted from the ME Network.
      • And it doesn't respect filter.toSlot.
    • MEBridgePeripheral.importChemical voids chemicals when the ME Network couldn't fit all the amount extracted from the target peripheral.
      • And it doesn't respect filter.fromSlot either.

Voiding chemicals causes some ethical issues around Nuclear Wastes similar to this.

  • What is the new behavior (if this is a feature change)?

    • MEBridgePeripheral.exportChemical no longer voids chemicals when the target peripheral couldn't fit all the amount extracted from the ME Network.
      • And it now also respects filter.toSlot.
    • MEBridgePeripheral.importChemical no longer voids chemicals when the ME Network couldn't fit all the amount extracted from the target peripheral.
      • And it now also respects filter.fromSlot.
  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Yes (Nuclear Wastes can no longer be destroyed in this way)

  • Other information:

…rting.

* ME Bridge now respects `toSlot` and `fromSlot` during exporting/importing chemical.
@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit a14cf62
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/17557139719
Jar Files AdvancedPeripherals PR 781
Expires At 2025-12-07T16:12:52Z

@SirEndii
SirEndii merged commit 0ef34c7 into IntelligenceModding:dev/1.21.1 Sep 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants