[FIX] add guidellm preflight check and pin vllm to <=0.19#17
Open
VincentG1234 wants to merge 5 commits into
Open
[FIX] add guidellm preflight check and pin vllm to <=0.19#17VincentG1234 wants to merge 5 commits into
VincentG1234 wants to merge 5 commits into
Conversation
Signed-off-by: Vincent Gimenes <vincent.gimenes@gmail.com>
hgsmn
reviewed
Apr 29, 2026
| return self._process | ||
|
|
||
| def _validate_guidellm_cli(self, env: dict[str, str]) -> None: | ||
| """Fail fast if GuideLLM cannot start due to dependency/import issues.""" |
Collaborator
There was a problem hiding this comment.
It is the only possible error when launching guidellm --help ?
Collaborator
Author
There was a problem hiding this comment.
no, but it is an easy way to catch problems early
| ["guidellm", "benchmark", "--help"], | ||
| capture_output=True, | ||
| text=True, | ||
| timeout=15, |
Collaborator
There was a problem hiding this comment.
15 second is not too short ?
Collaborator
Author
There was a problem hiding this comment.
Yes, I wanted to put 30 sec. I will modify
Signed-off-by: Vincent Gimenes <vincent.gimenes@gmail.com>
VincentG1234
force-pushed
the
fix/guidellm-cli-preflight
branch
from
75ec8cb to
30d5933
Compare
3 tasks
VincentG1234
added a commit
that referenced
this pull request
May 20, 2026
## Summary Add structured documentation for human maintainers and coding agents: `AGENTS.md`, `.ai/context/`, `.ai/skills/`, and a user-facing architecture guide with Mermaid diagrams. Link the new doc from README and quick start. Align the local example YAML with vLLM V1 constraints. ## Why The InseeFrLab fork needs a stable onboarding path for contributors and agents (local backend focus, safe commands, known issues/PRs) without reading the whole codebase. Architecture was previously only implicit in code; diagrams improve onboarding and reviews. ## What changed - `AGENTS.md` — entry point for agents (context files, skills, safe commands). - `.ai/context/` — repo map, execution flow, history, known issues, current work snapshot, external links. - `.ai/skills/` — pr-writer, pr-reviewer, test-writer, docs-writer, architecture-diagrams. - `docs/architecture.md` — end-to-end, layout, orchestration, trial lifecycle, outputs (Mermaid). - `README.md`, `docs/quick_start.md` — links to architecture doc. - `examples/study_config_local_exec.yaml` — disable `max_num_partial_prefills` (unsupported on V1; comment added). ## How tested - [x] `ruff check .` - [x] `pytest -v tests/` - [x] Manual E2E (maintainer): not required (docs-only PR) ## Risks / limitations - `.ai/context/current-work.md` is a point-in-time snapshot (open PRs #13, #17, #21, #22); it will drift until refreshed after merges. - Mermaid rendering depends on the viewer (GitHub, IDE); no runtime behavior change except the example YAML default. ## Links - (none — no issue closed) Signed-off-by: Vincent Gimenes <vincent.gimenes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Guidellm do not launch at the start of the vLLM server, leading to fail every trials. The error in #15 seems to come from vllm instead of transformers
#19
Summary
guidellm benchmark --helpbefore launching the benchmark process, with a short timeout.vllmto<=0.19inpyproject.tomlto avoid unsupported behavior with0.20.Why
Some trials were timing out because GuideLLM could crash at startup due to dependency/import issues. This change detects startup failures immediately and surfaces actionable diagnostics, while constraining
vllmto the supported version range.