Skip to content

feat: add filter for ucq based on a variable#1151

Merged
QRuhier merged 7 commits into
mainfrom
feat/filter-variable-based-qcu
Jun 16, 2026
Merged

feat: add filter for ucq based on a variable#1151
QRuhier merged 7 commits into
mainfrom
feat/filter-variable-based-qcu

Conversation

@QRuhier

@QRuhier QRuhier commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@QRuhier

QRuhier commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Needs to be done in Pogues-bo & Eno before merging
Or we can add a feature flag for not showing the optionFilter field in form (no risk of regression)

@QRuhier QRuhier changed the title feat: filter variable based qcu feat: add filter for ucq based on a variable Apr 20, 2026
@laurentC35

laurentC35 commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ pogues-model in version 1.15.5 is required in pogues-api and Eno !

need somes adpatation in Eno

@QRuhier

QRuhier commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

@laurentC35 Yeah i did InseeFr/Eno#1384
But when checking quickly with @nsenave it seems we have issue with ddi so it would need some changes

@sonarqubecloud

sonarqubecloud Bot commented May 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
79.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@QRuhier QRuhier force-pushed the feat/filter-variable-based-qcu branch from abdcd42 to 4448ee2 Compare June 9, 2026 08:01
@QRuhier

QRuhier commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

In the end we did not change the model : for ddi reason, we keep OptionFilter in the Question, assuming we handle it only for UCQ.
Then we disabled the field for filtering in table.

@QRuhier QRuhier requested a review from MailineN June 9, 2026 12:33
@QRuhier QRuhier force-pushed the feat/filter-variable-based-qcu branch from 53543b7 to a6b8031 Compare June 10, 2026 08:04
chloe-renaud
chloe-renaud approved these changes Jun 16, 2026
View reviewed changes

@chloe-renaud chloe-renaud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, love the comments, tests and changelog :)

@sonarqubecloud

sonarqubecloud Bot commented Jun 16, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@QRuhier QRuhier merged commit 36ade83 into main Jun 16, 2026
8 checks passed
@QRuhier QRuhier deleted the feat/filter-variable-based-qcu branch June 16, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chloe-renaud chloe-renaud chloe-renaud approved these changes

@laurentC35 laurentC35 Awaiting requested review from laurentC35

@MailineN MailineN Awaiting requested review from MailineN

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QRuhier @laurentC35 @chloe-renaud