fix(analytics): external-only metrics, person exclusions, ASC retries#1100
Merged
IgorGanapolsky merged 13 commits intodevelopfrom Apr 8, 2026
Merged
fix(analytics): external-only metrics, person exclusions, ASC retries#1100IgorGanapolsky merged 13 commits intodevelopfrom
IgorGanapolsky merged 13 commits intodevelopfrom
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
github-actions
bot
added
the
pr-state:ci_running
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+53
to
+55
| .onLongPressGesture { | ||
| proManager.unlockProForDebug() | ||
| } |
There was a problem hiding this comment.
Bug: A debug long-press gesture on the 'PRO' label that unlocks pro features is exposed in production builds, allowing users to bypass payment.
Severity: CRITICAL
Suggested Fix
Wrap the code that adds the long-press gesture recognizer and its handler in an #if DEBUG block. This ensures the debug functionality is only compiled into debug builds and is excluded from production builds.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: native-ios/RandomTimer/Sources/UI/Screens/TimerSetupScreen.swift#L53-L55
Potential issue: A long-press gesture on the 'PRO' label, intended for debugging,
unlocks pro features. This functionality was not wrapped in a conditional compilation
block like `#if DEBUG`. Consequently, this debug feature is included in production
builds, allowing any user to bypass payment and access pro features for free.
Did we get this right? 👍 / 👎 to inform future reviews.
native-android/app/src/main/java/com/iganapolsky/randomtimer/analytics/AnalyticsService.kt
Show resolved
Hide resolved
IgorGanapolsky
force-pushed
the
fix/ios-pro-unlock-longpress
branch
from
07f0174 to
95d76db
Compare
Contributor
|
❌ CI Some checks failed
|
Contributor
|
❌ CI Some checks failed
|
Contributor
|
❌ CI Some checks failed
|
Contributor
|
❌ CI Some checks failed
|
Contributor
|
❌ CI Some checks failed
|
- Tag distribution_channel on iOS (TestFlight vs App Store) and Android (Play vs non-Play) - Mark TestFlight and non-Play installs internal; HogQL excludes listed distribution channels - Align LIVE_EVENTS_PREDICATE across store snapshot, north star, attribution, posthog dashboard - POSTHOG_EXECUTIVE_EXCLUDE_PERSON_IDS in executive snapshot + CI workflow secret wiring - Redact excluded person UUIDs from committed executive_metrics.json audience_sql - ASC API retries with longer timeout; marketing/data README for operators - Tests: Android install channel, iOS DistributionChannelResolver, executive redaction Made-with: Cursor
PR #1073 hid lock icons and disabled paywall taps before first timer completion. This broke the freemium UX — new users couldn't see what Pro offers. All Pro features now always show lock icons and tap to show paywall regardless of first timer state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Every Pro feature MUST show a lock icon to free users on fresh install. These tests will fail if anyone hides Pro locks behind any condition. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Made-with: Cursor
Made-with: Cursor
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sumable UI Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
IgorGanapolsky
force-pushed
the
fix/ios-pro-unlock-longpress
branch
from
1d6a4e2 to
3bf4520
Compare
Made-with: Cursor
Contributor
|
❌ CI Some checks failed
|
Made-with: Cursor
|
Contributor
|
❌ CI Some checks failed
|
Contributor
|
❌ CI Some checks failed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distribution_channel+ internal tagging (TestFlight, non-Play installs)distribution_channeldenylist in LIVE_EVENTS_PREDICATE / pragmatic dashboardsPOSTHOG_EXECUTIVE_EXCLUDE_PERSON_IDSin executive snapshot + CI workflow secret (set on repo)audience_sqlin committed JSON (UUIDs not stored in git)marketing/data/README.md; docsEvidence
Commit:
7989c6540onfix/ios-pro-unlock-longpressNote: Branch name reflects prior iOS work; this commit is analytics-focused.
Made with Cursor