Open
Conversation
MarielaTihova
requested changes
Feb 11, 2026
| @@ -0,0 +1,305 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
You have this folder name for the 3 grids -> keyboard-navigation-guide and then for the hgrid you have one other folder called keyboard-custom-navigation. Why is that? Do we need it?
| }; | ||
|
|
||
| return ( | ||
| <div className="sample" style={{ display: 'grid', gridTemplateColumns: '1fr 360px', gap: 16 }}> |
Contributor
There was a problem hiding this comment.
Please put styles in the css file instead
| )} | ||
| {items.map((c: Item, idx: number) => ( | ||
| <IgrListItem key={idx} className={`${c.active ? 'active' : 'disabled'}`}> | ||
| <div style={{ display: 'flex', alignItems: 'center', gap: 12, width: '100%' }}> |
Contributor
There was a problem hiding this comment.
Same for styles in css file instead of inline styles in all of the divs above
| onColumnSelectionChanging={onColumnSelectionChanging as any} | ||
| > | ||
| <IgrPaginator /> | ||
| {/* Toolbar can be conditionally shown if needed */} |
Contributor
There was a problem hiding this comment.
Do we need this commented code?
| </div> | ||
|
|
||
| {/* Right-side list showing active/available shortcuts */} | ||
| <div className="list-sample" style={{ overflow: 'auto', height: '100vh', position: 'sticky', top: 0 }}> |
Contributor
There was a problem hiding this comment.
Styles in the css files. Please go through all 3 components and transfer them into css files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard nav samples for