test(grid): add conditionName sync coverage for Excel-style custom filter dialog#16933
Draft
Copilot wants to merge 2 commits intokeep-conditionName-synced-20.1.xfrom
Draft
test(grid): add conditionName sync coverage for Excel-style custom filter dialog#16933Copilot wants to merge 2 commits intokeep-conditionName-synced-20.1.xfrom
Copilot wants to merge 2 commits intokeep-conditionName-synced-20.1.xfrom
Conversation
14 tasks
Co-authored-by: hanastasov <14248932+hanastasov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on conditionName sync in grid
test(grid): add conditionName sync coverage for Excel-style custom filter dialog
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #16924 fixed
conditionNamenot being kept in sync when changing conditions in the ESF custom filter dialog (excel-style-default-expression.component.ts), but lacked test coverage for that path. This PR adds the missing test, mirroring the existing filtering row coverage.Changes
grid-filtering-ui.spec.ts— adds'Should keep conditionName in sync when changing condition in ESF custom dialog.'to the Excel style filtering suite. The test opens the ESF custom dialog forProductName, changes the condition fromcontains→startsWith, applies, then asserts viaverifyFilteringExpressionthat bothcondition.nameandconditionNameequal'startsWith'.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.