-
Notifications
You must be signed in to change notification settings - Fork 20
Integration tests: include MariaDB as well #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9a88abc to
55f0e41
Compare
55f0e41 to
5aa7439
Compare
5aa7439 to
41c31f2
Compare
|
While this PR was somewhat forgotten, I just thought about it in spite of #947. How about testing both the |
|
They're either not available or don't work and it's a bit out of scope here. |
b17d885 to
41c31f2
Compare
I wouldn't understand that comment if I didn't happen to look at this PR and it's pipelines at just the right moment by pure chance, i.e. at this run: https://github.com/Icinga/icingadb/actions/runs/17097225377 One job failed because there seems to be no
The other one failed with a MySQL error:
This also needs more context: that's an error from the database setup done by icinga-testing. |
|
Fixing that is trivial actually (if you know where to look), so I just created a PR for it: Icinga/icinga-testing#32 |
39f2210 to
36f9068
Compare
36f9068 to
fa0feb5
Compare
|
Again, what is the state of this PR, @Al2Klimov? Do you want to proceed here? It was quite hard for me to follow the conversion, especially with the time gap in between. |
just to be sure we're compatible with this RDBMS and not only MySQL.
fa0feb5 to
47dda14
Compare
|
Well, you asked #729 (comment) for also including the minimum required RDBMS versions, but this seemed not to work. I've rebased and hope for the best... |
|
Let's be honest, this is more or less a waste of resources. I would close the PR. |
|
But all checks pass now. |
just to be sure we're compatible with this RDBMS and not only MySQL.