Do 19 - list should be displayed based on object array#15
Open
faizahmed1234 wants to merge 3 commits into
Open
Do 19 - list should be displayed based on object array#15faizahmed1234 wants to merge 3 commits into
faizahmed1234 wants to merge 3 commits into
Conversation
faizahmed1234
changed the title
mjawaids
requested changes
Jan 3, 2023
| } | ||
|
|
||
| let currentView; | ||
| let projectList1 = { |
Contributor
There was a problem hiding this comment.
Why are there 2 lists projectList and projectList1?
| projectListArray = Object.keys(projectList1); | ||
| let projects = ""; | ||
| for (let i = 0; i < projectListArray.length; i++) { | ||
| projects +="<li class='list-unstyled px-3'>" + |
Contributor
There was a problem hiding this comment.
Variable projects should better be named projectsHtml.
| } | ||
|
|
||
|
|
||
| function showProjectList() { |
Contributor
There was a problem hiding this comment.
Projects list that need to be displayed should be passed in the function argument.
| <!-- Navigation Bar --> | ||
| <div class="row"> | ||
| <div class="col-3 collapse collapse-horizontal show" id="side-bar"> | ||
| <nav> |
Contributor
There was a problem hiding this comment.
Why it has been changed from nav to div?
| }] | ||
|
|
||
| let project1 = [{ | ||
| id: 10, |
Contributor
There was a problem hiding this comment.
Doest project1 contain tasks? What this list depicts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.