[IUS-2613] additional DataCORE actor unit tests#171
Open
rdlebeau wants to merge 3 commits into
Open
Conversation
rdlebeau
marked this pull request as draft
July 7, 2025 18:26
rdlebeau
force-pushed
the
IUS-2613_actor_unit_tests
branch
4 times, most recently
from
July 18, 2025 18:53
bd13e6e to
c0a2090
Compare
rdlebeau
marked this pull request as ready for review
July 18, 2025 19:47
rdlebeau
changed the title
rdlebeau
force-pushed
the
IUS-2613_actor_unit_tests
branch
from
September 5, 2025 20:41
c0a2090 to
9250e34
Compare
rdlebeau
force-pushed
the
IUS-2613_actor_unit_tests
branch
from
September 8, 2025 20:03
9250e34 to
ce97fc8
Compare
Contributor
Author
|
The metadata_filename_collection, metadata_filename_collection_work, and metadata_filename_work functions in the yaml_populate_service.rb file were not in use and were the same as the functions of the same name in metadata_helper.rb |
rdlebeau
changed the title
rdlebeau
marked this pull request as draft
October 15, 2025 16:54
rdlebeau
changed the title
rdlebeau
marked this pull request as ready for review
October 15, 2025 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The revert_content function in file_set_actor.rb does not have a "work" variable, so I removed the reference to it in the Rails.logger.error message. I suspect it was copy-pasted from the attach_to_work function, which does have a "work" variable.