Migrate workflow callers to ITensorActions v2#32
Merged
Merged
Conversation
Same shape as the ecosystem-wide v2 sweep, applied manually here so the existing repo-specific xvfb / OpenGL inputs in Tests.yml and Documentation.yml are preserved (the standard sweep patch overwrites caller files entirely and would clobber them). Changes: - Workflow `name:` / job display `name:` match filename basename (e.g. `IntegrationTest.yml` -> `name: "IntegrationTest"`). - Job keys kebab-case lowercase; brand names like `tagbot`, `compathelper` treated as single words. - `uses: ITensorActions/.../X.yml@v1` -> `@v2`. - `FormatCheckComment.yml` workflow_run trigger from `["Format Check"]` to `["FormatCheck"]`. - Explicit `permissions:` blocks added to every caller workflow that was missing one (matching the ITensorPkgSkeleton template shape). - Repo-specific `apt-packages`, `test-prefix`, `doc-prefix`, `extra-env`, `upload-artifacts-path`, and the `os: ubuntu-22.04` Documentation pin are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual application of the ecosystem-wide v2 sweep, with this repo's existing repo-specific inputs (xvfb, apt-packages, etc.) preserved. The standard
MassApplyPatchsweep was applied to every other ecosystem repo, but skipped here because that patch overwrites caller workflow files entirely and would clobber the repo-specific reusable inputs needed for headless OpenGL CI.Changes
name:and primary inner-job displayname:match the file's basename (e.g.IntegrationTest.yml→name: "IntegrationTest").tagbot,compathelper) treated as single words.uses: ITensor/ITensorActions/.../X.yml@v1→@v2.FormatCheckComment.ymlworkflow_runtrigger updated fromworkflows: ["Format Check"]to["FormatCheck"].permissions:blocks added to every caller workflow that was missing one (matching theITensorPkgSkeletontemplate shape).Preserved repo-specific inputs
The following remain unchanged:
Tests.ymlreusable inputs:apt-packages,test-prefix,extra-env,upload-artifacts-path. These set up xvfb + OpenGL packages so GLMakie tests can run headlessly on Linux.Documentation.ymlreusable inputs:apt-packages,doc-prefix, plus theos: "ubuntu-22.04"runner pin.Tests.ymlOS matrix restricted toubuntu-latestonly (macOS/Windows GitHub runners do not have working OpenGL drivers).The
os: "ubuntu-22.04"Documentation pin can probably be removed in a follow-up since v2 of the reusable fixes thexvfb-runshell-quoting regression that originally motivated it. Keeping the pin defensively for now.