Generalize block sparse matricize#163
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 75.95% 75.37% -0.59%
==========================================
Files 36 37 +1
Lines 2059 2091 +32
==========================================
+ Hits 1564 1576 +12
- Misses 495 515 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrite block sparse
matricize/unmatricizeto callmatricize/unmatricizeblockwise, while before it called out toblockreshape. The previous logic was too limited when the blocks themselves have more structure and we don't want to simplyreshapethem, for example for Kronecker blocks.This is breaking because it makes the
blocksparseconstructor stricter, now you can callblocksparse(d, [2, 3], [2, 3])orblocksparse(d, blockedrange.(([2, 3], [2, 3])))but notblocksparse(d, ([2, 3], [2, 3]))orblocksparse(d, blockedrange.(([2, 3], [2, 3]))...). That matches the convention in BlockArrays.jl constructors and avoids ambiguities since an input likeblocksparse(d, Base.OneTo(3))would be ambiguous otherwise (it wouldn't be clear if those should be block lengths or the axis).