Added method for prompt generation from raw data#272
Merged
Conversation
dmjoy
requested changes
Apr 28, 2026
| if callable(system_prompt_template): | ||
| system_prompt = call_with_coerced_args( | ||
| system_prompt_template, | ||
| {'model':self.structured_inference_engine.model} |
Contributor
There was a problem hiding this comment.
Wondering why we aren't initializing this component with structured_inference_engine and instead opting to pass in the model and create a new generator (looks like we're just passing in the structured_inference_engine.model anyway). Are there parameters that need to be different or are we otherwise invoking this differently that makes this necessary? The main detractor to doing it this way is that we can't freely swap out the inference engine backend.
Contributor
|
Merging as-is, but when / if we need to revisit we should opt to use the |
dmjoy
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two phase approach for prompt generation:
phase2_direct_gen.yaml shows how this can be configured for medical kdma.