add monocole ts for all properties operations - #8
Conversation
|
@IMax153 can you please CR? all the tests are passing ofcourse |
|
Hey @regevbr! Thank you so much for the PR - the lib is definitely well past due for an update, so this is much appreciated! I’m on vacation for the next two weeks, but once I have a chance to sit down in front of my computer I will take a look and approve! |
| "fp-ts": "^2.10.5", | ||
| "monocle-ts": "^2.3.10" |
There was a problem hiding this comment.
In thinking about this PR further, the addition of monocle-ts as a peer-dependency of expressive-ts would be considered a breaking change for users of the library. The update to the fp-ts version is also a soft breaking change, since it's a peer dependency of the lib.
I would like to avoid implementing any breaking changes until the fp-ts@3.0.0 release, at which point we can collaborate on a revamp of the entire expressive-ts library.
We can leave this PR open until then if that is alright?
|
@IMax153 thanks for the CR! Can you please approve the workflow so the CI can run for this PR? |
2 participants
This PR replaces all the
{...obj}usages in the code to use the awesome gcanti/monocle-ts library.I couldn't help myself and I also updated some dependencies, fixed deprecated usages of fp-ts and transformed
toFlagsto be more "functional". I also made the CI run on PRs