Feature/improve scoping of custom runner aspect #1759#1850
Open
dbinkele wants to merge 14 commits into
Open
Conversation
…coping-of-CustomRunnerAspect-#1759 # Conflicts: # code/languages/org.iets3.opensource/solutions/org.iets3.opensource.build/models/org/iets3/opensource/build/build.mps
Merges files build-testInterpreter.xml & build-testInterpreter2.xml Purpose is to get a working ant file from both to run InterpreterTests
…coping-of-CustomRunnerAspect-#1759
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1759
Problem
A
CustomRunnerAspectcould only reference solutions within its own containing root, because the scope of the runner'ssolutionreference link was restricted to the descendants of the containing build project. This made it impossible to compose a proper MPS build for command-line interpreter test runs (and blocked #1751, which builds on this).Changes
org.iets3.opensource.build.gentests): The reference scope ofCustomRunnerAspectis now aCompositeScopethat combines the existingDescendantsScopewith additional scopes, so aCustomRunnerAspectcan referenceBuildMps_Solutions defined outside its containing root.<taskdef resource="…/antlib.xml">) so the emittedrunMPStask resolves — previously the generatedbuild-testInterpreter2.xmlfailed with "failed to create task or type runMPS".execTestsByInterpreterinto a…Prestep plus the main task driving the newbuild-testInterpreterExec.xmlscript, so interpreter tests run end-to-end from the command line.org.iets3.opensource.build/allScripts.buildsolutions and references.Testing
./gradlew execTestsByInterpreterruns to completion (BUILD SUCCESSFUL) and produces the interpreter test reports underbuild/generatedXMLs/.