Expose filename errors in the ETC log#447
Merged
Merged
Conversation
ggVGc
approved these changes
May 29, 2026
ggVGc
left a comment
Contributor
There was a problem hiding this comment.
Looks alright, but would prefer keeping the exception handling (logging non-fatal errors) in appendError or appendLogMsgToFile, or at least make those methods return a Try rather than Unit.
Jonathan-Schenk
approved these changes
May 29, 2026
Jonathan-Schenk
left a comment
Contributor
There was a problem hiding this comment.
Looks fine and I do not have anything to add. @ggVGc raises a good point I think.
Contributor
Author
|
In 448d1f9, I adjusted the ETC filename parse error logging to write only err.getMessage to errorLog.txt, instead of using UploadResult.extractMessage, because that included stack traces for regular exceptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We return a 400 error when the filename used by a logger doesn't match the pattern we've agreed on with ETC. However, when logger upload data directly, nobody monitors and sees these errors.
This change will append the errors to the log file we provide to ETC.