Skip to content

Expose filename errors in the ETC log#447

Merged
jonathanthiry merged 2 commits into
masterfrom
etc-uploads-400-log
May 29, 2026
Merged

Expose filename errors in the ETC log#447
jonathanthiry merged 2 commits into
masterfrom
etc-uploads-400-log

Conversation

@jonathanthiry

Copy link
Copy Markdown
Contributor

We return a 400 error when the filename used by a logger doesn't match the pattern we've agreed on with ETC. However, when logger upload data directly, nobody monitors and sees these errors.

This change will append the errors to the log file we provide to ETC.

@ggVGc ggVGc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, but would prefer keeping the exception handling (logging non-fatal errors) in appendError or appendLogMsgToFile, or at least make those methods return a Try rather than Unit.

@Jonathan-Schenk Jonathan-Schenk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and I do not have anything to add. @ggVGc raises a good point I think.

@jonathanthiry jonathanthiry merged commit e2134c7 into master May 29, 2026
1 check passed
@jonathanthiry jonathanthiry deleted the etc-uploads-400-log branch May 29, 2026 14:31
@jonathanthiry

Copy link
Copy Markdown
Contributor Author

In 448d1f9, I adjusted the ETC filename parse error logging to write only err.getMessage to errorLog.txt, instead of using UploadResult.extractMessage, because that included stack traces for regular exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants