Added early exit without doing regex matches for masking pattern layout #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return mask(super.doLayout(event)); | ||
| } | ||
|
|
||
| private String mask(String message) { |
Contributor
There was a problem hiding this comment.
This method was meant to be generic but right now it's quite specific to S3 presigned URL redaction, I suggest keeping it generic by at least renaming the constants to be specific to AWS S3 presigned URL masking
Something along the lines of:
- maskPattern -> AWS_PRESIGNED_URL_REGEX_PATTERN
- maskBroadCheckSubstring -> AWS_SECURITY_TOKEN_HEADER
- maskedRedaction -> AWS_PRESIGNED_URL_REDACTION_MASK
This makes it obvious that the method is generic and new logic/constants can be added as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks with different frequency of maskable logs. Real world logs probably have lower than 10% maskable log lines and so would yield an improvement of between 87-98%.
JFR Profiling results on validator show CPU Use share down from 18% to 0.002%