Generic JSON encoder for case-classes#546
Open
otto-dev wants to merge 2 commits into
Open
Conversation
Author
|
CI fails with a python syntax error thrown by a third party module |
Contributor
|
I think it would be better to choose the most standard way in the ecosystem and put these instances into |
Author
|
Sounds good to me. As long as you have a way to delegate the encoder creation to Scala. Planning to have a look when I find time, unless someone beats me to it. I first have to set up the build & test environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows conversion of any Scala case class and tuples to/from JSON by importing
mist.api.encoding.defaults._. Makes it unnecessary to create encoders for case classes.Encoders for specific classes (case classes) will continue to take precedence over this generic encoder and extractor. Hence the ability to create specific encoders remains unaffected, and existing code will not break.
Derived from the examples in the documentation. I can't build and test mist locally beyond compilation because of time constrains.
I'm not sure if the import of
shadedshapeless.Lazyis necessary.Also, feel free to reject this pull request if there is a reason why this hasn't been implemented yet.