Skip to content

Generic JSON encoder for case-classes#546

Open
otto-dev wants to merge 2 commits into
Hydrospheredata:masterfrom
otto-dev:feature/product_enc
Open

Generic JSON encoder for case-classes#546
otto-dev wants to merge 2 commits into
Hydrospheredata:masterfrom
otto-dev:feature/product_enc

Conversation

@otto-dev

@otto-dev otto-dev commented Jul 2, 2019

Copy link
Copy Markdown

Allows conversion of any Scala case class and tuples to/from JSON by importing mist.api.encoding.defaults._. Makes it unnecessary to create encoders for case classes.

Encoders for specific classes (case classes) will continue to take precedence over this generic encoder and extractor. Hence the ability to create specific encoders remains unaffected, and existing code will not break.

Derived from the examples in the documentation. I can't build and test mist locally beyond compilation because of time constrains.

I'm not sure if the import of shadedshapeless.Lazy is necessary.

Also, feel free to reject this pull request if there is a reason why this hasn't been implemented yet.

@otto-dev

otto-dev commented Jul 2, 2019

Copy link
Copy Markdown
Author

CI fails with a python syntax error thrown by a third party module pytest

@otto-dev otto-dev closed this Jul 2, 2019
@otto-dev otto-dev reopened this Jul 2, 2019
@dos65

dos65 commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

I think it would be better to choose the most standard way in the ecosystem and put these instances into auto object. Like circe and pureconfig do this.

@otto-dev

otto-dev commented Jul 3, 2019

Copy link
Copy Markdown
Author

Sounds good to me. As long as you have a way to delegate the encoder creation to Scala. Planning to have a look when I find time, unless someone beats me to it. I first have to set up the build & test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants