Mozilla branding removal - #272
Conversation
|
Thank you for the pull request. ROADMAP STATUS: This pull request isn't currently on any roadmap. Updates will be conveyed here as its place on/off a roadmap changes. You can view the roadmaps here: Roadmaps Google Drive folder. For more information on how the roadmaps work, see our roadmaps policy on GitHub. |
|
This PR is intended to contribute toward the existing "Remove Mozilla branding" roadmap item in the Communication & Documentation Team roadmap. The changes focus on a small set of repository/package metadata and documentation references that still pointed to Mozilla-owned repositories, branding, or support channels. If there is a preferred process for associating a PR with an existing roadmap item, please let me know and I'd be happy to update it accordingly. AI tools (ChatGPT) were used to assist with drafting and structuring parts of this change. |
Exairnous
added
the
Roadmap: Communication & Documentation
|
@HussainAther There's nothing you need to do to with regard to associating PRs with roadmaps. |
Exairnous
left a comment
Exairnous
left a comment
There was a problem hiding this comment.
@HussainAther
You need to drop commit 4c6b5c0, but aside from that, it looks pretty good. I've left a few inline comments, but they should be very easy to sort out.
| ``` | ||
| ### done ### | ||
| -rw-r--r--@ 1 mozilla staff {timestamp} ./.retpack/retpack.tar.gz | ||
| -rw-r--r--@ 1 username staff {timestamp} ./.retpack/retpack.tar.gz |
There was a problem hiding this comment.
I believe that what was mozilla staff is actually the user and group, so I would put this as either user group or root root (which is what was shown to me when I ran bash retpack.sh).
This is what my terminal printed out:
-rw-r--r-- 1 root root 24M Jun 4 03:16 ./.retpack/retpack.tar.gz
| 2. The terminal command may take several minutes to complete depending on the quantity and nature of your customization. **Do not exit the terminal until the upload process has completed.** Once successfully complete, it will return `done, reqId: <unique-ID-string>`. After a few minutes, you should see your customization on your Hub. | ||
|
|
||
| 3. After deploying, try to create a room to verify your customizations have taken place. If you are unable to see your customizations, email [hubs-feedback@mozilla.com](mailto:hubs-feedback@mozilla.com) with the subject line `Hubs Custom Client Deployment Troubleshooting` and a description of your problem. | ||
| 3. After deploying, try to create a room to verify your customizations have taken place. If you are unable to see your customizations, email [info@hubsfoundation.org](mailto:info@hubsfoundation.org) with the subject line `Hubs Custom Client Deployment Troubleshooting` and a description of your problem. |
There was a problem hiding this comment.
I would rather not have the raw email address of the Hubs Foundation here. Usually, we've been URL encoding the email address for things like this, but since this page is probably going to be either deleted or completely rewritten, I would just put in placeholder values for now (also, we probably don't want anyone emailing us for support anyway - they should go to Discord for that).
| 3. After deploying, try to create a room to verify your customizations have taken place. If you are unable to see your customizations, email [info@hubsfoundation.org](mailto:info@hubsfoundation.org) with the subject line `Hubs Custom Client Deployment Troubleshooting` and a description of your problem. | |
| 3. After deploying, try to create a room to verify your customizations have taken place. If you are unable to see your customizations, email [hubs-feedback@example.com](mailto:hubs-feedback@example.com) with the subject line `Hubs Custom Client Deployment Troubleshooting` and a description of your problem. |
| pkg_description="Docs for Hubs + Spoke by Mozilla" | ||
| pkg_upstream_url="https://hubs.mozilla.com/docs" | ||
| pkg_description="Docs for Hubs + Spoke" | ||
| pkg_upstream_url="https://docs.hubsfoundation.org" |
There was a problem hiding this comment.
We've been using the GitHub URL for stuff like this, rather than Hubs Foundation deployments of the GitHub repos.
| pkg_upstream_url="https://docs.hubsfoundation.org" | |
| pkg_upstream_url="https://github.com/Hubs-Foundation/hubs-docs" |
78a03de to
c165241
Compare
|
ty for the review. addressed the inline comments, updated the upstream URL to the GitHub repository, removed the support email reference in favor of Discord guidance, and dropped commit 4c6b5c0 from the branch history. take another look when you have a chance? |
|
@HussainAther Thank you for your update. While you have dropped the extraneous commit I mentioned, there are now 41 unrelated commits prior to yours that need to be removed. If you can describe what you did to drop the commit/get it into this state, I can potentially walk you through how to fix it. Aside from that, it looks like my comment for line 59 of |
|
I’ll get to this soon.
Last night I used a “git log oneline” method to do so
Syed Hussain Ather (he/him)
<https://github.com/hussainather>
<https://scholar.google.com/citations?user=jPL2-dEAAAAJ&hl=en>
<https://www.linkedin.com/in/syed-hussain-ather-049919137/>
<https://twitter.com/shussainather>
http://hussainather.com
…On Sat, Jun 20, 2026 at 3:07 AM Exairnous ***@***.***> wrote:
*Exairnous* left a comment (Hubs-Foundation/hubs-docs#272)
<#272 (comment)>
@HussainAther <https://github.com/HussainAther> Thank you for your update.
While you have dropped the extraneous commit I mentioned, there are now 41
unrelated commits prior to yours that need to be removed. If you can
describe what you did to drop the commit/get it into this state, I can
potentially walk you through how to fix it.
Aside from that, it looks like my comment for line 59 of
docs/setup-custom-client.mdx hasn't been addressed yet; however, don't
worry about that now. After the 41 unrelated commits are fixed, I'll add a
suggestion for it that you can just apply.
—
Reply to this email directly, view it on GitHub
<#272?email_source=notifications&email_token=AB44CMOOYQDRX4NHZUHCGMD5AYZ2VA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZVGY4DANZVHE22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4756807595>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB44CMNH5EJ5EC6AGFX4C435AYZ2VAVCNFSNUABFKJSXA33TNF2G64TZHMZDCOJYGI2TKMRVHNEXG43VMU5TINJYGA3DGMBWG4ZKC5QC>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
c165241 to
686def3
Compare
|
Hey, so it looks like I accidentally rebased/reset against the wrong history and pulled unrelated upstream commits into my branch. I’m going to reset my branch cleanly to the current |
|
fixed remaining setup-custom-client example to use the user/group values discussed in review. |
Exairnous
left a comment
Exairnous
left a comment
There was a problem hiding this comment.
Thank you for the update. This looks good now. Merging.
2 participants
What?
This pull request removes removes several remaining Mozilla-branded repository, package, and support references from hubs-docs.
Changes include:
Why?
The Hubs Foundation is continuing the Mozilla Branding Removal effort across Hubs-related repositories.
These references were no longer accurate and could cause confusion about project ownership, support channels, and repository locations.
Limitations
This pull request intentionally focuses on a small set of clearly outdated branding references. These ones seemed obvious enough to begin some meaningful changes.
Historical attribution, licenses, contributor information, and references to Mozilla resources that are still relevant (such as MDN documentation) were left unchanged.
More branding cleanup work may remain elsewhere in the repository. Further clarification may be needed for changing email addresses or other official domains.
Additional details or related context
This PR is part of the the ongoing Mozilla Branding Removal effort referenced in the Communication & Documentation Team roadmap and Mozilla Branding Removal Guidelines.