WIP: Add docker-compose.yml and fix nginx paths for resources (Issue #211) - #212
WIP: Add docker-compose.yml and fix nginx paths for resources (Issue #211)#212ajlennon wants to merge 2 commits into
Conversation
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
|
An unfortunate complication is that Hubs in some places refers to |
Exairnous
left a comment
There was a problem hiding this comment.
I believe the issue with building the Docker image is because of us moving away from using /docs/. This was introduced with #203 but no one thought about updating the Docker image or its nginx configuration. So I think that rather than adding more redirects for /docs/ we should be removing them. Actually, it looks like modifying the initial redirect to the following should make everything work again (and no other redirects should be needed):
location / {
root /var/www/docs;
autoindex off;
add_header 'Access-Control-Allow-Origin' '*';
}
@DougReeder Does the above seem plausible to you and in line with your changes?
| hubs-docs: | ||
| build: . | ||
| ports: | ||
| - "8080:8080" |
There was a problem hiding this comment.
Consider whethere exposing the server on port 80 would make sense.
That's cleaner. I think it should be |
|
Using |
What: Added the docker-compose.yml from PR 212, but instead of adding further redirects for `/docs/` to the nginx.config the root location is set to go to the internal /var/www/docs. Why: This keeps it in line with the changes introduced in PR Hubs-Foundation#203 and is a simpler solution. Note: This has already been communicated to PR Hubs-Foundation#212, so this commit is only for archival purposes.
What?
Allows a user to locally build and run a docker container hosting the documentation webserver
Why?
Makes it easy to build and run the documentation server locally without making host OS changes
Examples
How to test
docker compose builddocker compose upThen browse to localhost:8080/docs
NOTE I don't know if these changes break the CI deployment to the official server
Documentation of functionality
N/A
Limitations
Might impact CI deployment
Alternatives considered
Open questions
Does this impact CI deployment
Additional details or related context