Restrict dialog workflow to minimum required permissions - #65
Merged
Conversation
What: sets the permissions of the dialog workflow to none. Why: to minimize the chance of the workflow being hacked and in preparation to globally restrict permissions for all Hubs Foundation workflows. Note: the permissions setting was advised by `GitHubSecurityLab/actions-permissions/monitor@bf82d13b9b10051d224345ab9184f5ede0a94289 #v1 Beta 9`
|
Thank you for the pull request. ROADMAP STATUS: This pull request isn't currently on any roadmap. Updates will be conveyed here as its place on/off a roadmap changes. You can view the roadmaps here: Roadmaps Google Drive folder. For more information on how the roadmaps work, see our roadmaps policy on GitHub. |
62 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Sets the permissions of the dialog workflow to none.
Why?
To minimize the chance of the workflow being hacked and in preparation to globally restrict permissions for all Hubs Foundation workflows.
Examples
N/A
How to test
Documentation of functionality
This doesn't change the functionality of the workflow, so no documentation update is needed.
Known limitations
None.
Alternative implementations considered
None.
Open questions
None.
Additional details or related context
The permissions setting was advised by
GitHubSecurityLab/actions-permissions/monitor@bf82d13b9b10051d224345ab9184f5ede0a94289 #v1 Beta 9Companion to: Hubs-Foundation/hubs-ops#215
Part of Hubs-Foundation/.github#13