sat: add debug and warning logs for transmission and ephemeris#195
Merged
Conversation
github-actions
Bot
requested review from
HongNguyen635,
buckleypaul and
hunterhubble
Add debug logs to track the time-since-sync interval, additional retries computed from TDR, and the final retry count/interval used when sending packets. Add warning logs on DTM packet get and transmission failures so errors are visible in the log output Signed-off-by: Flavio Ceolin <flavio@hubble.com>
Instrument hubble_sat_ephemeris.c with HUBBLE_LOG_DEBUG/WARNING calls to trace configuration, search inputs, results, and error paths. Signed-off-by: Flavio Ceolin <flavio@hubble.com>
hunterhubble
approved these changes
May 7, 2026
HongNguyen635
approved these changes
May 8, 2026
Collaborator
HongNguyen635
left a comment
HongNguyen635
left a comment
There was a problem hiding this comment.
A minor comment but looks good to me.
| lon_tol = _lon_tolerance_get(pos->lat, alt); | ||
| int ret = _pass_get(&_satellites[i], t, pos, lon_tol, &next_pass); | ||
|
|
||
| if (ret == 0) { |
Collaborator
There was a problem hiding this comment.
would it be helpful if we can log which sat it succesfully computed for?
Collaborator
Author
There was a problem hiding this comment.
There is a following log for success, and a valid pass here is not necessarily the returned value so it can be misleading. The sat id info should be only for the returned pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add useful debug / warning messages around satellite common code.