Skip to content

fix(config): keep path suffix out of project overrides#2776

Merged
Hmbown merged 1 commit into
codex/v0.9.0-stewardshipfrom
codex/harden-path-suffix-project-config
Jun 5, 2026
Merged

fix(config): keep path suffix out of project overrides#2776
Hmbown merged 1 commit into
codex/v0.9.0-stewardshipfrom
codex/harden-path-suffix-project-config

Conversation

@Hmbown
Copy link
Copy Markdown
Owner

@Hmbown Hmbown commented Jun 5, 2026

Summary

  • prevent repo-local project config from overriding provider path_suffix
  • keep path_suffix aligned with the existing project-config policy that ignores endpoint routing fields
  • extend the project-override regression test to cover path_suffix

Verification

  • cargo test -p codewhale-config --locked project_merge_denies_credentials_endpoints_and_provider_selection -- --nocapture
  • cargo test -p codewhale-tui --bin codewhale-tui --locked api_url_with_suffix -- --nocapture
  • cargo fmt --all -- --check
  • git diff --check

Credit

Follow-up hardening for the provider path-suffix feature from #2558, with review coverage noted on related PRs #2506/#2508.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@Hmbown Hmbown merged commit 0b07b81 into codex/v0.9.0-stewardship Jun 5, 2026
2 checks passed
@Hmbown Hmbown deleted the codex/harden-path-suffix-project-config branch June 5, 2026 04:04
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the merging of path_suffix from project-level provider configurations in merge_project_provider_config. It also adds corresponding test cases to verify that the base configuration's path_suffix is not overwritten by the project configuration. No review comments were provided, so there is no feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant