Skip to content

test(shell): widen background completion wait #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyq1017 wants to merge 1 commit into from
Closed

test(shell): widen background completion wait #2528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/tui/src/tools/shell/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ fn env_lock() -> &'static Mutex<()> {
LOCK.get_or_init(|| Mutex::new(()))
}

const BACKGROUND_COMPLETION_WAIT_MS: u64 = 30_000;

fn echo_command(message: &str) -> String {
format!("echo {message}")
}
Expand Down Expand Up @@ -175,7 +177,7 @@ fn test_background_execution() {

// Wait for completion
let final_result = manager
.get_output(&task_id, true, 5000)
.get_output(&task_id, true, BACKGROUND_COMPLETION_WAIT_MS)
.expect("get_output");

assert_eq!(final_result.status, ShellStatus::Completed);
Expand Down Expand Up @@ -758,7 +760,7 @@ async fn test_completed_background_shell_releases_process_handles() {
json!({
"task_id": task_id.clone(),
"wait": true,
"timeout_ms": 5_000
"timeout_ms": BACKGROUND_COMPLETION_WAIT_MS
}),
&ctx,
)
Expand Down
Loading