Skip to content

fix(android): harden profile validation and log buffering#21

Merged
Hidden-Node merged 1 commit into
Hidden-Node:mainfrom
AmirrezaFarnamTaheri:codex/android-validation-log-resolver-hardening
May 13, 2026
Merged

fix(android): harden profile validation and log buffering#21
Hidden-Node merged 1 commit into
Hidden-Node:mainfrom
AmirrezaFarnamTaheri:codex/android-validation-log-resolver-hardening

Conversation

@AmirrezaFarnamTaheri
Copy link
Copy Markdown
Contributor

What changed:

  • VpnManager: replaced repeated log-list copying with a bounded ArrayDeque ring buffer.
  • VpnManager: batches log UI emissions every 150ms during bursts while still parsing scan/status lines immediately.
  • ConfigGenerator: resolver generation now deduplicates by normalized endpoint key, preserving different ports like 1.1.1.1:53 and 1.1.1.1:5353.
  • ProfilesScreen: profile save now shows clear inline errors for missing name, domain, encryption key, or resolvers.
  • ProfilesScreen: removed silent default resolver/profile-name fallback on save/import, so broken profiles are not quietly created.
  • strings.xml: added validation messages.

@Hidden-Node
Copy link
Copy Markdown
Owner

Hidden-Node commented May 13, 2026

Excellent work on the log buffering and validation logic. The batching update (150ms) is a great catch for UI performance. Merging now.

@Hidden-Node Hidden-Node merged commit 64e1b6a into Hidden-Node:main May 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants